Re: [PATCH 5.15 047/155] jbd2: remove journal_clean_one_cp_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 01, 2023 at 03:09:44PM +0200, Jan Kara wrote:
> On Tue 01-08-23 11:19:19, Greg Kroah-Hartman wrote:
> > From: Zhang Yi <yi.zhang@xxxxxxxxxx>
> > 
> > [ Upstream commit b98dba273a0e47dbfade89c9af73c5b012a4eabb ]
> > 
> > journal_clean_one_cp_list() and journal_shrink_one_cp_list() are almost
> > the same, so merge them into journal_shrink_one_cp_list(), remove the
> > nr_to_scan parameter, always scan and try to free the whole checkpoint
> > list.
> > 
> > Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx>
> > Reviewed-by: Jan Kara <jack@xxxxxxx>
> > Link: https://lore.kernel.org/r/20230606135928.434610-4-yi.zhang@xxxxxxxxxxxxxxx
> > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> > Stable-dep-of: 46f881b5b175 ("jbd2: fix a race when checking checkpoint buffer busy")
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> 
> This and the following patch (46f881b5b175) have some issues [1] and cause a
> performance regression for some workloads and possible metadata corruption
> after a crash. So please drop these two patches from the stable trees for
> now. We can include them again later once the code has stabilized...
> Thanks!

Thanks, turns out there were 3 patches here (2 prep patches, one fix)
that needed to be dropped from all queues.  Let us know when the fix is
in Linus's tree so we can add them back in.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux