On 28. 07. 2023. 21:58, Luis Chamberlain wrote:
> On Fri, Jul 28, 2023 at 09:48:08PM +0200, Mirsad Todorovac wrote:
>> v3 -> v4
>> - fix additional memory leaks of the allocated firmware buffers
>> - fix noticed racing conditions in conformance with the existing code
>> - make it a single patch
>
> This is not quite right.
>
> Your patch commit 48e156023059 ("test_firmware: fix the memory leak of
> the allocated firmware buffer" is already upstream and now you're taking
> that same patch and modifying it?
Hello, Luis,
Yes, you are right, this was the wrong patch. I don't know how I did this
because I wasn't intoxicated nor high. :-/
Now I saw that I started the entire discussion in the wrong thread, and then
assumed that this was the right patch, so it is entirely my fault.
They say that assumption is the mother of all blunders.
> If you have something else you want to fix you can use the latest
> lib/firmware.c refelected on linux-next and send a patch against that
> to augment with more fixes.
>
> If your goal however, is to make sure these patches end up in v5.4
> (as I think you are trying based on your last email) you first send
> a patch matching exactly what is in the upstream commit for inclusion
> in v5.4. Do not modify the commit unless you are making changes need
> to be made due to backporting, and if you do you specify that at the
> bottommon of the commit after singed offs of before in brackets
> [like this].
I think I intended just that, for the racing condition fix to be applied to the
v5.4 stable tree, too.
> Furthermore, I see you have other fixes other than this one merged
> already on upstream so if you need those for v5.4 you need to send those
> too.
Thanks,
Mirsad
--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union
"I see something approaching fast ... Will it be friends with me?"
