On 7/24/23 4:25?PM, Linus Torvalds wrote: > On Mon, 24 Jul 2023 at 11:48, Christian Brauner <brauner@xxxxxxxxxx> wrote: >> >> It's really just keeping in mind that refcount rules change depending on >> whether fds or fixed files are used. > > This sentence still worries me. > > Those fixed files had better have their own refcounts from being > fixed. So the rules really shouldn't change in any way what-so-ever. > So what exactly are you alluding to? They do, but they only have a single reference, which is what fixes them into the io_uring file table for fixed files. With the patch from the top of this thread, that should then be fine as we don't need to artificially elevator the ref count more than that. -- Jens Axboe
