Re: [PATCH 6.4.y] i2c: busses: i2c-nomadik: Remove a useless call in the remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 23/07/2023 à 22:34, Greg KH a écrit :
On Fri, Jul 21, 2023 at 07:47:41PM +0200, Christophe JAILLET wrote:
Since commit 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba
driver"), there is no more request_mem_region() call in this driver.

So remove the release_mem_region() call from the remove function which is
likely a left over.

Fixes: 235602146ec9 ("i2c-nomadik: turn the platform driver to an amba driver")
Cc: <stable@xxxxxxxxxxxxxxx> # v3.6+
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
The patch below that should fix a merge conflict related to commit
9c7174db4cdd1 ("i2c: nomadik: Use devm_clk_get_enabled()") has been
HAND MODIFIED.
I don't understand, that commit is not in the stable trees.  What do you
mean by "hand modified"?

I hope it is fine, but is provided as-is. Especially line numbers should be
wrong, but 'patch' should be able to deal with it. (sorry if it does not apply)

I guess that it should also apply to all previous branches.

I've left the commit description as it was. Not sure what to do with A-b and R-b
tags.
Why isn't this needed in Linus's tree?

If *this* is the patch --> see my other reply.


If *this* is the A-b and R-b tags, knowing that it is a *modified version* of what they agreed, I'm not sure that the tags are still relevant. They agreed with the patch in a *given context*. That does not mean that an updated patch is still correct in another context and that they still agree with it.

That' why I wonder.

CJ



confused,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux