On Mon, Jul 24, 2023 at 2:20 PM Xiubo Li <xiubli@xxxxxxxxxx> wrote:
>
>
> On 7/24/23 19:12, Ilya Dryomov wrote:
> > On Mon, Jul 24, 2023 at 10:44 AM <xiubli@xxxxxxxxxx> wrote:
> >> From: Xiubo Li <xiubli@xxxxxxxxxx>
> >>
> >> Flushing the dirty buffer may take a long time if the Rados is
> >> overloaded or if there is network issue. So we should ping the
> >> MDSs periodically to keep alive, else the MDS will blocklist
> >> the kclient.
> >>
> >> Cc: stable@xxxxxxxxxxxxxxx
> > Hi Xiubo,
> >
> > The stable tag doesn't make sense here as this commit enhances commit
> > 2789c08342f7 ("ceph: drop the messages from MDS when unmounting") which
> > isn't upstream. It should probably just be folded there.
>
> No, Ilya. This is not an enhancement for commit 2789c08342f7.
>
> They are for different issues here. This patch just based on that. We
> can apply this first and then I can rebase the testing branch.
Ah, thanks for letting me know. Please go ahead and structure it that
way in the testing branch. As it is, it conflicts heavily as the enum
that it adds a new member to was added in commit 2789c08342f7.
Ilya
