Re: Potential USB PHY error handling fix for stable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 29, 2014 at 10:54:35PM +0000, Mark Brown wrote:
> On Wed, Oct 29, 2014 at 03:30:18PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Oct 29, 2014 at 10:10:12PM +0000, Mark Brown wrote:
> 
> > > One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb:
> > > phy: return -ENODEV on failure of try_module_get) as a fix for the
> > > stable kernel.  While it's error handling that's being fixed this does
> > > seem like a reasonable candidate, it's a very simple fix and the
> > > behaviour without the change is to return a NULL pointer rather than an
> > > error pointer which callers will interpret as success which isn't good.
> 
> > > Does this seem reasonable?
> 
> > What stable kernel are you referring to?  This patch is in 3.17 already,
> > and 3.16 is now end-of-life after this next release in a few hours.
> 
> It applies to v3.14 as well, I didn't check further back.

It goes further back than that, but since nobody complained so far, I'm
ok with v3.14 only if Greg accepts that.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]