Re: [PATCH] MIPS: Loongson: Fix cpu_probe_loongson() again

["Maciej W. Rozycki" <macro@xxxxxxxxxxx>]

On Mon, 26 Jun 2023, Huacai Chen wrote:

> diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> index e79adcb128e6..b406d8bfb15a 100644
> --- a/arch/mips/kernel/cpu-probe.c
> +++ b/arch/mips/kernel/cpu-probe.c
> @@ -1677,7 +1677,10 @@ static inline void decode_cpucfg(struct cpuinfo_mips *c)
>  
>  static inline void cpu_probe_loongson(struct cpuinfo_mips *c, unsigned int cpu)
>  {
> +	c->cputype = CPU_LOONGSON64;
> +
>  	/* All Loongson processors covered here define ExcCode 16 as GSExc. */
> +	decode_configs(c);
>  	c->options |= MIPS_CPU_GSEXCEX;

 This has misplaced the comment, which is not about `decode_configs' at 
all.  For consistency with other code it also seems like `decode_configs' 
would best be called as the first statement of `cpu_probe_loongson'.

  Maciej