On Sun, Jul 16, 2023 at 11:28:20AM +1200, Michael Schmitz wrote: > The Amiga partition parser module uses signed int for partition sector > address and count, which will overflow for disks larger than 1 TB. > > Use u64 as type for sector address and size to allow using disks up to > 2 TB without LBD support, and disks larger than 2 TB with LBD. The RBD > format allows to specify disk sizes up to 2^128 bytes (though native > OS limitations reduce this somewhat, to max 2^68 bytes), so check for > u64 overflow carefully to protect against overflowing sector_t. > > Bail out if sector addresses overflow 32 bits on kernels without LBD > support. > > This bug was reported originally in 2012, and the fix was created by > the RDB author, Joanne Dow <jdow@xxxxxxxxxxxxx>. A patch had been > discussed and reviewed on linux-m68k at that time but never officially > submitted (now resubmitted as patch 1 in this series). > This patch adds additional error checking and warning messages. > > Reported-by: Martin Steigerwald <Martin@xxxxxxxxxxxx> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=43511 > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Message-ID: <201206192146.09327.Martin@xxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # 5.2 > Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20230620201725.7020-4-schmitzmic@xxxxxxxxx > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > (cherry picked from commit b6f3f28f604ba3de4724ad82bea6adb1300c0b5f) > Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx> > > --- > > Changes since 5.10-stable: > > - fix merge conflicts > --- All now queued up, thanks. greg k-h
