Re: [PATCH v4 1/1] block: bugfix for Amiga partition overflow check patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On 5/07/23 21:08, Geert Uytterhoeven wrote:

Fixes: b6f3f28f60 ("block: add overflow checks for Amiga partition support")
Message-ID: 024ce4fa-cc6d-50a2-9aae-3701d0ebf668@xxxxxxxxxxx
Please drop this line.
Because it's redundant, as I've also used Link:?
(That, too ;-)

Because the use of the Message-ID: tag in patches is not documented.

Now I wonder where I picked up that habit ...

IIRC, it might also cause issues when applying, as the downloaded patch
will appear to have two Message-IDs.
That's correct (if you refer to a patch in mbox format), but from the context of the two Message-ID lines, it ought to be clear which one matters.
I'm not sure the sample git hook in Documentation/maintainer/configure-git.rst
(and all variants the various maintainers are using) handles this correctly.

You're right, it won't check for context there.

In this particular instance, it won't use my Message-ID tag anyway though (forgot the angle brackets).

I'll fix that in v5 later.

Cheers,

    Michael



Gr{oetje,eeting}s,

                         Geert




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux