On Mon, Jul 03, 2023 at 10:19:29AM +0200, Takashi Iwai wrote:
> Isn't it rather an issue about the error code passing in qcom driver?
> How about the change like below?
>
>
> Takashi
>
> --- a/sound/soc/qcom/qdsp6/topology.c
> +++ b/sound/soc/qcom/qdsp6/topology.c
> @@ -1276,10 +1276,8 @@ int audioreach_tplg_init(struct snd_soc_component *component)
> }
>
> ret = snd_soc_tplg_component_load(component, &audioreach_tplg_ops, fw);
> - if (ret < 0) {
> - dev_err(dev, "tplg component load failed%d\n", ret);
> - ret = -EINVAL;
> - }
> + if (ret < 0)
> + dev_err_probe(dev, ret, "tplg component load failed %d\n", ret);
That looks like a sensible change in general anyway.
Attachment:
signature.asc
Description: PGP signature
