On Fri, Jun 30, 2023 at 11:00:51AM +0530, Naresh Kamboju wrote: > On Fri, 30 Jun 2023 at 00:18, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > This is the start of the stable review cycle for the 6.4.1 release. > > There are 28 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sat, 01 Jul 2023 18:41:39 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.4.1-rc1.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.4.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > Results from Linaro’s test farm. > > Following build regression noticed on Linux stable-rc 6.4 and also noticed on > Linux mainline master. > > Regressions found on Parisc and Sparc build failed: > - build/gcc-11-defconfig > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx> > > Parisc Build log: > ============= > arch/parisc/mm/fault.c: In function 'do_page_fault': > arch/parisc/mm/fault.c:292:22: error: 'prev' undeclared (first use in > this function) > 292 | if (!prev || !(prev->vm_flags & VM_GROWSUP)) > | ^~~~ > arch/parisc/mm/fault.c:292:22: note: each undeclared identifier is > reported only once for each function it appears in > > > sparc Build log: > =========== > <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] > arch/sparc/mm/fault_32.c: In function 'force_user_fault': > arch/sparc/mm/fault_32.c:315:49: error: 'regs' undeclared (first use > in this function) > 315 | vma = lock_mm_and_find_vma(mm, address, regs); > | ^~~~ > arch/sparc/mm/fault_32.c:315:49: note: each undeclared identifier is > reported only once for each function it appears in > > > Links: > - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4-29-g8e5ddb853f08/testrun/17959811/suite/build/test/gcc-11-defconfig/details/ > - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4-29-g8e5ddb853f08/testrun/17959811/suite/build/test/gcc-11-defconfig/log > > - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4-29-g8e5ddb853f08/testrun/17959890/suite/build/test/gcc-11-defconfig/details/ > - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.4.y/build/v6.4-29-g8e5ddb853f08/testrun/17959890/suite/build/test/gcc-11-defconfig/log > > > Both build failures noticed on mainline and sparc build have been > fixed yesterday. > - https://qa-reports.linaro.org/lkft/linux-mainline-master/build/v6.4-8542-g82a2a5105589/testrun/17963192/suite/build/test/gcc-11-defconfig/history/ > > > Following patch that got fixed > --- > >From 0b26eadbf200abf6c97c6d870286c73219cdac65 Mon Sep 17 00:00:00 2001 > From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Date: Thu, 29 Jun 2023 20:41:24 -0700 > Subject: sparc32: fix lock_mm_and_find_vma() conversion > > The sparc32 conversion to lock_mm_and_find_vma() in commit a050ba1e7422 > ("mm/fault: convert remaining simple cases to lock_mm_and_find_vma()") > missed the fact that we didn't actually have a 'regs' pointer available > in the 'force_user_fault()' case. > > It's there in the regular page fault path ("do_sparc_fault()"), but not > the window underflow/overflow paths. > > Which is all fine - we can just pass in a NULL pointer. The register > state is only used to avoid deadlock with kernel faults, which is not > the case for any of these register window faults. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Fixes: a050ba1e7422 ("mm/fault: convert remaining simple cases to > lock_mm_and_find_vma()") > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Thanks! That saves me having to dig. I'll go push out updates with this in them... greg k-h
