> > +static int lan743x_csr_wait_for_bit_atomic(struct lan743x_adapter *adapter, > > adapter is not used in readx_poll_timeout_atomic() call, right? > can be removed. I thought that when i first looked at an earlier version of this patch. But LAN743X_CSR_READ_OP is not what you think :-( Andrew