Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-10-27 at 20:40 +0100, Oliver Neukum wrote:
> On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote:
> 
> > I guess we could use that quirk, but I'm actually leaning towards just
> > removing that quirk and reducing the log level of the message to info.
> > 
> > Oliver, what do you say?
> 
> Now that I think about this, I'd say that we should actually
> export the flag via sysfs and ask the ModemManager people
> to honour it.

And we'd be happy to do that in ModemManager.  However:

[24919.251413] usb 2-6: New USB device found, idVendor=0421,
idProduct=03d2
[24919.251425] usb 2-6: New USB device strings: Mfr=2, Product=3,
SerialNumber=4
[24919.251431] usb 2-6: Product: Nokia N950
[24919.251437] usb 2-6: Manufacturer: Nokia
[24919.251442] usb 2-6: SerialNumber: xxxxx
[24919.255343] cdc_acm 2-6:1.7: This device cannot do calls on its own.
It is not a modem.
[24919.255434] cdc_acm 2-6:1.7: ttyACM0: USB ACM device

lt-ModemManager[13913]: <debug> [1414441686.310970]
[mm-port-serial-at.c:440] debug_log(): (ttyACM0): --> 'ATD*99***2#<CR>'
lt-ModemManager[13913]: <debug> [1414441686.357306]
[mm-port-serial-at.c:440] debug_log(): (ttyACM0): <--
'<CR><LF>CONNECT<CR><LF>'

nm-pppd-plugin-Message: nm-ppp-plugin: (nm_phasechange): status 8 /
phase 'network'
local  IP address 33.197.88.195
remote IP address 10.6.6.6
primary   DNS address 10.177.0.34

so whenever that flag gets exported, we also need to make sure that
things that the kernel says *aren't* modems, actually aren't modems.
Which we apparently get wrong right now for various Nokia devices.  I
don't really trust the manufacturers to set the right descriptor bits
for their devices, even Nokia.

Dan
----
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        7
      bAlternateSetting       0
      bNumEndpoints           1
      bInterfaceClass         2 Communications
      bInterfaceSubClass      2 Abstract (modem)
      bInterfaceProtocol      1 AT-commands (v.25ter)
      iInterface             11 CDC Abstract Control Model (ACM)
      CDC Header:
        bcdCDC               1.10
      CDC Call Management:
        bmCapabilities       0x00
        bDataInterface          8
      CDC ACM:
        bmCapabilities       0x02
          line coding and serial state
      CDC Union:
        bMasterInterface        7
        bSlaveInterface         8 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x87  EP 7 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x000a  1x 10 bytes
        bInterval               9
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        8
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass        10 CDC Data
      bInterfaceSubClass      0 Unused
      bInterfaceProtocol      0 
      iInterface             12 CDC ACM Data
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x86  EP 6 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x05  EP 5 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]