Hi! > From: Steve French <stfrench@xxxxxxxxxxxxx> > > [ Upstream commit b535cc796a4b4942cd189652588e8d37c1f5925a ] > > If plen is null when passed in, we only checked for null > in one of the two places where it could be used. Although > plen is always valid (not null) for current callers of the > SMB2_change_notify function, this change makes it more consistent. Changelog explains problem can not happen, so... is this important enough to backport? Best regards, Pavel > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Closes: https://lore.kernel.org/all/202305251831.3V1gbbFs-lkp@xxxxxxxxx/ > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > fs/cifs/smb2pdu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index 537e8679900b8..3ca593cdda76e 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -3779,7 +3779,7 @@ SMB2_change_notify(const unsigned int xid, struct cifs_tcon *tcon, > if (*out_data == NULL) { > rc = -ENOMEM; > goto cnotify_exit; > - } else > + } else if (plen) > *plen = le32_to_cpu(smb_rsp->OutputBufferLength); > } > -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
