Hi!
> [ Upstream commit 9b9e46aa07273ceb96866b2e812b46f1ee0b8d2f ]
>
> This patch fixes the error checking in nfcsim.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
I don't think this is good idea; user will wonder why he can't see
debugfs files, and pr_err() is quite suitable way to handle this.
Anyway, this does not really fix a bug, so we should not be putting it
into stable.
Best regards,
Pavel
> drivers/nfc/nfcsim.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c
> index 533e3aa6275cd..cf07b366500e9 100644
> --- a/drivers/nfc/nfcsim.c
> +++ b/drivers/nfc/nfcsim.c
> @@ -345,10 +345,6 @@ static struct dentry *nfcsim_debugfs_root;
> static void nfcsim_debugfs_init(void)
> {
> nfcsim_debugfs_root = debugfs_create_dir("nfcsim", NULL);
> -
> - if (!nfcsim_debugfs_root)
> - pr_err("Could not create debugfs entry\n");
> -
> }
>
> static void nfcsim_debugfs_remove(void)
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Attachment:
signature.asc
Description: PGP signature
