Re: [PATCH v10 2/3] block: change annotation of rdb_CylBlocks in affs_hardblocks.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christoph,

Am 15.06.2023 um 17:53 schrieb Christoph Hellwig:
On Thu, Jun 15, 2023 at 04:50:45PM +1200, Michael Schmitz wrote:
And as far as I can tell everything that is a __u32 here should
be an __be32 because it is a big endian on-disk format.  Why
would you change only a single field?

Because that's all I needed, and wanted to avoid excess patch churn. Plus
(appeal to authority here :-)) it's in keeping with what Al Viro did when
the __be32 annotations were first added.

I can change all __u32 to __be32 and drop the comment if that's preferred.

That would be great!

OK, will respin tomorrow.

Cheers,

	Michael




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux