On Thu, Jun 08, 2023 at 04:21:32PM +0200, Jerome Neanne wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> The driver's probe() first registers regulators in a loop and then in a
> second loop passes them as irq data to the interrupt handlers. However
> the function to get the regulator for given name
> tps65219_get_rdev_by_name() was a no-op due to argument passed by value,
> not pointer, thus the second loop assigned always same value - from
> previous loop. The interrupts, when fired, where executed with wrong
> data. Compiler also noticed it:
>
> drivers/regulator/tps65219-regulator.c: In function ‘tps65219_get_rdev_by_name’:
> drivers/regulator/tps65219-regulator.c:292:60: error: parameter ‘dev’ set but not used [-Werror=unused-but-set-parameter]
>
> Fixes: c12ac5fc3e0a ("regulator: drivers: Add TI TPS65219 PMIC regulators support")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> Signed-off-by: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> ---
>
> Notes:
> This is backport of upstream fix in TI mainline:
> Link: https://lore.kernel.org/all/20230507144656.192800-1-krzysztof.kozlowski@xxxxxxxxxx/
What is the upstream commit id here?
thanks,
greg k-h
