Re: Wrong/strange TPM patches was Re: [PATCH 6.1 000/119] 6.1.31-rc1 review

[Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>]

On Tue, May 30, 2023 at 6:46 AM Pavel Machek <pavel@xxxxxxx> wrote:
>
> > Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx>
> >     tpm, tpm_tis: Avoid cache incoherency in test for interrupts
>
> Description on this one is wrong/confused.

Yes. Commit 858e8b792d06 ("tpm, tpm_tis: Avoid cache incoherency in
test for interrupts") in mainline.

The change to test_bit/set_bit may be a good one (and adding the
IRQ_TESTED case to the bit flags), but that commit wasn't it.

As you say, the enum should now enumerate bits, not bitmasks.

             Linus