Hi! I found a regression in DMA handling on one of our SAMA5D3 boards. While combing through the regressing commit, a found two unrelated strange things. The first is the actually problematic change. The second is a number of suspect defines, that I fail to see how they can ever do any good. Cheers, Peter Changes since v1 [1], after comments from Tudor Ambarus: Patch 1/2: - Don't convert to inline functions. - Cc stable Patch 2/2: - Extend the field instead of killing "too big" field values. - Add Fixes and R-b tags. - Cc stable [1] https://lore.kernel.org/lkml/dc4834cb-fadf-17a5-fbc7-cf500db88f20@xxxxxxxxxx/ Peter Rosin (2): dmaengine: at_hdmac: Repair bitfield macros for peripheral ID handling dmaengine: at_hdmac: Extend the Flow Controller bitfield to three bits drivers/dma/at_hdmac.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 2.20.1