From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> commit 5e1617210aede9f1b91bb9819c93097b6da481f9 upstream. This reverts commit a3afbf5cc887fc3401f012fe629810998ed61859. This depends on commit 0db213ea8eed ("usb: gadget: udc: core: Invoke usb_gadget_connect only when started") that introduces a regression, revert it till the issue is fixed. Cc: stable@xxxxxxxxxxxxxxx Reported-by: Stephan Gerhold <stephan@xxxxxxxxxxx> Reported-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> Link: https://lore.kernel.org/all/ZF4BvgsOyoKxdPFF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> Link: https://lore.kernel.org/r/20230512131435.205464-2-francesco@xxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/usb/gadget/udc/core.c | 3 --- 1 file changed, 3 deletions(-) --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -676,9 +676,6 @@ static int usb_gadget_connect_locked(str goto out; } - if (gadget->connected) - goto out; - if (gadget->deactivated || !gadget->udc->started) { /* * If gadget is deactivated we only save new state.