Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/05/2023 18:39, Bart Van Assche wrote:

Hi Bart,

       *args->resid = scmd->resid_len;
-    if (args->sense)
-        memcpy(args->sense, scmd->sense_buffer, SCSI_SENSE_BUFFERSIZE);
+    if (args->sense) {
+        *args->sense = scmd->sense_buffer;
+        scmd->sense_buffer = NULL;

I think that you will agree that this is not a good pattern to follow. We cannot have SCSI core allocating the sense buffer but a driver freeing it.

Thanks,
John



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux