On Tuesday 09 May 2023 17:14:48 Michael Ellerman wrote: > Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes: > > Hi-- > > > > Just a heads up. This patch can cause build errors. > > I sent a patch for these on 2023-APR-28: > > https://lore.kernel.org/linuxppc-dev/20230429043519.19807-1-rdunlap@xxxxxxxxxxxxx/ > > > > Michael, I think this is your area if I'm not mistaken. > > Yes. The fix is in my fixes branch as: > 536d948a8dee ("powerpc/fsl_uli1575: fix kconfig warnings and build errors") > > But I don't think this commit (22fdf79171e8) really warrants going to > stable, it's a nice-to-have but doesn't fix any pressing bugs. Exactly. And also this patch alone without 1/8 would not work as in 1/8 https://lore.kernel.org/all/20230409000812.18904-2-pali@xxxxxxxxxx/ was added static inline variant of function which is used when ULI is disabled. > cheers > > > On 5/8/23 20:54, Sasha Levin wrote: > >> From: Pali Rohár <pali@xxxxxxxxxx> > >> > >> [ Upstream commit 22fdf79171e8509db54599fd2c05ef0022ee83f5 ] > >> > >> ULI1575 PCIe south bridge exists only on some Freescale boards. Allow to > >> disable CONFIG_FSL_ULI1575 symbol when it is not explicitly selected and > >> only implied. This is achieved by marking symbol as visible by providing > >> short description. Also adds dependency for this symbol to prevent enabling > >> it on platforms on which driver does not compile. > >> > >> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > >> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > >> Link: https://msgid.link/20230409000812.18904-7-pali@xxxxxxxxxx > >> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > >> --- > >> arch/powerpc/platforms/Kconfig | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig > >> index d41dad227de84..608ac0290e3aa 100644 > >> --- a/arch/powerpc/platforms/Kconfig > >> +++ b/arch/powerpc/platforms/Kconfig > >> @@ -261,7 +261,9 @@ config CPM2 > >> on it (826x, 827x, 8560). > >> > >> config FSL_ULI1575 > >> - bool > >> + bool "ULI1575 PCIe south bridge support" > >> + depends on FSL_SOC_BOOKE || PPC_86xx > >> + select FSL_PCI > >> select GENERIC_ISA_DMA > >> help > >> Supports for the ULI1575 PCIe south bridge that exists on some > > > > -- > > ~Randy
