From: Liang He <windhl@xxxxxxx> commit ffef73791574b8da872cfbf881d8e3e9955fc130 upstream. In ad5755_parse_fw(), we should add fwnode_handle_put() when break out of the iteration device_for_each_child_node() as it will automatically increase and decrease the refcounter. Fixes: 3ac27afefd5d ("iio:dac:ad5755: Switch to generic firmware properties and drop pdata") Signed-off-by: Liang He <windhl@xxxxxxx> Link: https://lore.kernel.org/r/20230322035627.1856421-1-windhl@xxxxxxx Cc: <Stable@xxxxxxxxxxxxxxx> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/iio/dac/ad5755.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -802,6 +802,7 @@ static struct ad5755_platform_data *ad57 return pdata; error_out: + fwnode_handle_put(pp); devm_kfree(dev, pdata); return NULL; }