On Fri, Apr 21, 2023 at 12:42:30PM -0600, Mark Hasemeyer wrote: > commit 08d0cc5f34265d1a1e3031f319f594bd1970976c upstream. > > This change is desired because without it, it has been observed that > re-applying aspm settings can cause the system to crash with certain pci > devices (ie. Genesys GL9755). > > Tested by issuing 100 suspend/resume cycles on a symptomatic system running > 5.15.107. > > L1 settings looked identical before and after: > ``` > localhost ~ # lspci -vvv -d 0x17a0: | grep L1Sub > L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+ L1_PM_Substates+ > L1SubCtl1: PCI-PM_L1.2- PCI-PM_L1.1+ ASPM_L1.2- ASPM_L1.1+ > L1SubCtl2: T_PwrOn=3100us > ``` > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.15.y Odd, it does not apply cleanly, so how was this tested? Can you please send the tested backport that you have so we know to get it correct? thanks, greg k-h