On Tue, Apr 18, 2023 at 12:53:25 PM +0200, Greg KH wrote:
> On Tue, Apr 18, 2023 at 11:49:04AM +0200, Greg KH wrote:
>> On Wed, Apr 12, 2023 at 09:56:07AM +0530, Chandan Babu R wrote:
>> > Hi Greg,
>> >
>> > This 5.4.y backport series contains XFS fixes from v5.11 & v5.12. The
>> > patchset has been acked by Darrick.
>> >
>> > As a side note, where applicable, patches have been cherry picked from
>> > 5.10.y rather than from v5.11/v5.12.
>>
>> all now queued up, thanks.
>
> Wait, did you miss commit ada49d64fb35 ("xfs: fix forkoff miscalculation
> related to XFS_LITINO(mp)")?
Yes, unfortunately I missed that commit.
I always invoked my "find fixes" script as shown below,
# find-fixes-for-xfs-fixes.sh v5.11 v6.2 ~/junk/commits-fixes.log
The commits to be searched for "fixes for backported commits" spanned from the
kernel from which the fixes were backported to the latest upstream kernel. I
passed v5.11 as the argument since I was backporting patches from v5.11 and
v5.12.
However, e9e2eae89ddb ("xfs: only check the superblock version for dinode size
calculation") was from v5.7 and hence I missed ada49d64fb35.
# find-fixes-for-xfs-fixes.sh v5.4 v6.2 ~/junk/commits-fixes.log
ada49d64fb3538144192181db05de17e2ffc3551 e9e2eae89ddb
I will test the fix and send it out soon.
--
chandan
