Re: [PATCH] KVM: arm64: vgic: Don't acquire its_lock before config_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 12 Apr 2023 06:27:33 +0000, Oliver Upton wrote:
> commit f00327731131 ("KVM: arm64: Use config_lock to protect vgic
> state") was meant to rectify a longstanding lock ordering issue in KVM
> where the kvm->lock is taken while holding vcpu->mutex. As it so
> happens, the aforementioned commit introduced yet another locking issue
> by acquiring the its_lock before acquiring the config lock.
> 
> This is obviously wrong, especially considering that the lock ordering
> is well documented in vgic.c. Reshuffle the locks once more to take the
> config_lock before the its_lock. While at it, sprinkle in the lockdep
> hinting that has become popular as of late to keep lockdep apprised of
> our ordering.

Applied to next, thanks!

[1/1] KVM: arm64: vgic: Don't acquire its_lock before config_lock
      commit: 49e5d16b6fc003407a33a9961b4bcbb970bd1c76

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux