Re: [PATCH 6.1.y 1/3] drm/i915: Split icl_color_commit_noarm() from skl_color_commit_noarm()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 12, 2023 at 08:17:57AM +0200, Greg KH wrote:
> On Tue, Apr 11, 2023 at 06:51:52PM +0300, Ville Syrjälä wrote:
> > On Tue, Apr 11, 2023 at 03:58:49PM +0200, Greg KH wrote:
> > > On Mon, Apr 03, 2023 at 07:26:16PM +0300, Ville Syrjala wrote:
> > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > > > 
> > > > We're going to want different behavior for skl/glk vs. icl
> > > > in .color_commit_noarm(), so split the hook into two. Arguably
> > > > we already had slightly different behaviour since
> > > > csc_enable/gamma_enable are never set on icl+, so the old
> > > > code was perhaps a bit confusing as well.
> > > > 
> > > > Cc: <stable@xxxxxxxxxxxxxxx> #v5.19+
> > > > Cc: <stable@xxxxxxxxxxxxxxx> # 05ca98523481: drm/i915: Use _MMIO_PIPE() for SKL_BOTTOM_COLOR
> > > > Cc: Manasi Navare <navaremanasi@xxxxxxxxxx>
> > > > Cc: Drew Davenport <ddavenport@xxxxxxxxxxxx>
> > > > Cc: Imre Deak <imre.deak@xxxxxxxxx>
> > > > Cc: Jouni Högander <jouni.hogander@xxxxxxxxx>
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > > > Link: https://patchwork.freedesktop.org/patch/msgid/20230320095438.17328-2-ville.syrjala@xxxxxxxxxxxxxxx
> > > > Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
> > > > (cherry picked from commit f161eb01f50ab31f2084975b43bce54b7b671e17)
> > > > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> > > > (cherry picked from commit 76b767d4d1cd052e455cf18e06929e8b2b70101d)
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++++++++++++++-
> > > >  1 file changed, 20 insertions(+), 1 deletion(-)
> > > 
> > > This commit breaks the build.
> > 
> > You did cherry pick all the dependencies I listed?
> 
> Nope!  When you send a patch series, I had assumed that it was
> self-contained :(

I can do that in the future if it's preferred. But that does
seem to imply that there's no point in even listing the
dependencies.

Hmm, I suppose it can still be useful if one manages to list
the dependencies in the original commit. But generating such
a list upfront (accounting each relevant stable branch) doesn't
seem particularly appetizing for a fast moving target like i915.

-- 
Ville Syrjälä
Intel



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux