Re: [PATCH 5.4] smb3: fix problem with null cifs super block with previous patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 05, 2023 at 03:57:09PM +0200, Pratyush Yadav wrote:
> From: Steve French <stfrench@xxxxxxxxxxxxx>
> 
> [ Upstream commit 87f93d82e0952da18af4d978e7d887b4c5326c0b ]
> 
> Add check for null cifs_sb to create_options helper
> 
> Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
> Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx>
> Signed-off-by: Pratyush Yadav <ptyadav@xxxxxxxxx>
> ---
> 
> Only compile-tested. This was discovered by our static code analysis
> tool. I do not use CIFS and do not know how to actually reproduce the
> NULL dereference.
> 
> Follow up from [0]. Original patch is at [1].
> 
> Mandatory text due to licensing terms:
> 
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.

What?  That's funny.  And nothing I'm going to be adding to the
changelog text, sorry, as that's not what is upstream.  Please go poke
your lawyers, that's not ok.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux