On Wed, Apr 05 2023, Greg KH wrote: > On Wed, Apr 05, 2023 at 02:26:04PM +0200, Greg KH wrote: >> On Wed, Apr 05, 2023 at 01:47:52PM +0200, Pratyush Yadav wrote: >> > On Wed, Apr 05 2023, kernel test robot wrote: >> > >> > > Hi, >> > > >> > > Thanks for your patch. >> > > >> > > FYI: kernel test robot notices the stable kernel rule is not satisfied. >> > > >> > > Rule: 'Cc: stable@xxxxxxxxxxxxxxx' or 'commit <sha1> upstream.' >> > >> > I think the robot should also learn to look at the 'To:' header :-) >> >> Nope, the robot is correct, you submitted this incorrectly. > > Wait, maybe, I can't tell. My point is that it does not matter much if stable@xxxxxxxxxxxxxxx is in Cc or To. It gets the email regardless. In fact, that seems quite a common practice to me [0][1]. So I'd say it would be nice if the robot did not needlessly complain about this. > Please send this again and provide a whole lot more detail as to why > this is not relevant for upstream. I went and took another look. It seems that this was also fixed in upstream but in a slightly different way [2]. I will backport that patch instead of this one. [0] https://lore.kernel.org/stable/20230403140414.236685532@xxxxxxxxxxxxxxxxxxx/ [1] https://lore.kernel.org/stable/20230403140415.140110769@xxxxxxxxxxxxxxxxxxx/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=87f93d82e0952da18af4d978e7d887b4c5326c0b -- Regards, Pratyush Yadav Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
