Re: [PATCH 5.10 051/173] net: dsa: mt7530: move setting ssc_delta to PHY_INTERFACE_MODE_TRGMII case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 04, 2023 at 01:43:32PM +0200, Pavel Machek wrote:
Hi!

> > [ Upstream commit 407b508bdd70b6848993843d96ed49ac4108fb52 ]
> >
> > Move setting the ssc_delta variable to under the PHY_INTERFACE_MODE_TRGMII
> > case as it's only needed when trgmii is used.
>
> This one is very wrong for 5.10. ssc_delta is unconditionally used
> below, and it will not use uninitialized variable.
>
> (In mainline, that code is protected by if (trgint), so it does not
> have this problem).

This patch is not stable material in the first place. As a newbie I
incorrectly sent it to net tree instead of net-next. This patch can just be
ignored for 5.10, if that takes the least amount of effort for you folks.

Sorry about that and thanks for pointing this out Pavel.

I believe you did the right thing, but as it had Fixes header stable
people picked it up.

Right. I'll drop it.

--
Thanks,
Sasha



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux