On Tue, Oct 07, 2014 at 05:35:13PM +0530, Amit Shah wrote: > On (Mon) 06 Oct 2014 [18:10:40], Michael S. Tsirkin wrote: > > On restore, virtio pci does the following: > > + set features > > + init vqs etc - device can be used at this point! > > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > > > This is in violation of the virtio spec, which > > requires the following order: > > - ACKNOWLEDGE > > - DRIVER > > - init vqs > > - DRIVER_OK > > > > This behaviour will break with hypervisors that assume spec compliant > > behaviour. It seems like a good idea to have this patch applied to > > stable branches to reduce the support butden for the hypervisors. > > > > Cc: stable@xxxxxxxxxxxxxxx > > Cc: Amit Shah <amit.shah@xxxxxxxxxx> > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > I didn't see my previous questions answered from the initial posting > -- can you please respond to them? > > Amit Ooops missed your mail. Will respond now. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html