On Mon, Apr 03, 2023 at 12:09:09PM +0300, Peter Ujfalusi wrote: > The original patch uses a feature in lib/vsprintf.c to handle the invalid > address when tring to print *_fw_module->man4_module_entry.name when the > *rc_fw_module is NULL. > This case is handled by check_pointer_msg() internally and turns the > invalid pointer to '(efault)' for printing but it is hiding useful > information about the circumstances. Change the print to emmit the name > of the widget and a note on which side's fw_module is missing. > > Fixes: e3720f92e023 ("ASoC: SOF: avoid a NULL dereference with unsupported widgets") > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Link: https://lore.kernel.org/alsa-devel/4826f662-42f0-4a82-ba32-8bf5f8a03256@kili.mountain/ > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> > --- Thanks! regards, dan carpenter