Alistair Popple <apopple@xxxxxxxxxx> writes: > John Hubbard <jhubbard@xxxxxxxxxx> writes: > >> On 3/28/23 20:16, Matthew Wilcox wrote: >> ... >>>> + if (!get_page_unless_zero(vmf->page)) >>>> + return 0; >>> From a folio point of view: what the hell are you doing here? Tail >>> pages don't have individual refcounts; all the refcounts are actually > > I had stuck with using the page because none of this stuff (yet) > supports compound pages anyway so we shouldn't see a tail page > anyway. But point taken, I admit I need to find some time to get a > deeper internalised understanding of folios than just s/page/folio. And looking at this while updating it made the mixed usage of page/folio look really werid/wrong so thanks for pointing that out. Will send an update.
