On Wed, 15 Mar 2023 at 23:54, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Mar 15, 2023 at 11:49:00PM +0530, Amit Pundir wrote: > > This reverts commit 7b642273438cf500d36cffde145b9739fa525c1d which is > > commit 1dc3459009c33e335f0d62b84dd39a6bbd7fd5d2 upstream. > > > > This patch broke RB5 (Qualcomm SM8250) devboard. The device > > reboots into USB crash dump mode after following error: > > > > qcom_q6v5_pas 17300000.remoteproc: fatal error received: \ > > ABT_dal.c:278:ABTimeout: AHB Bus hang is detected, \ > > Number of bus hang detected := 2 , addr0 = 0x3370000 , addr1 = 0x0!!! > > > > Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx> > > --- > > sound/soc/codecs/lpass-rx-macro.c | 8 ++++---- > > sound/soc/codecs/lpass-tx-macro.c | 8 ++++---- > > sound/soc/codecs/lpass-va-macro.c | 20 ++++++++++---------- > > sound/soc/codecs/lpass-wsa-macro.c | 9 +++++---- > > 4 files changed, 23 insertions(+), 22 deletions(-) > > Is this also reverted in Linus's tree? If not, why not? I couldn't reproduce this crash on Linus's tree. It was first reported on android14-6.1 and then I could reproduce it on v6.1.19 as well, hence this revert. A quick search points out that this patch is a part of a 8 patch series https://lore.kernel.org/lkml/20230209122806.18923-1-srinivas.kandagatla@xxxxxxxxxx/ while only 5 of them landed on v6.1.y. May be we need the remaining fixes on v6.1.y as well? I can give the remaining patches a quick shot tomorrow if that helps. Regards, Amit Pundir > > thanks, > > greg k-h