On Tue, Mar 07, 2023 at 07:23:10PM +0000, Eric Biggers wrote:
> On Tue, Mar 07, 2023 at 06:02:02PM +0100, Greg Kroah-Hartman wrote:
> > From: Jan Kara <jack@xxxxxxx>
> >
> > commit 0813299c586b175d7edb25f56412c54b812d0379 upstream.
> >
> > When we are renaming a directory to a different directory, we need to
> > update '..' entry in the moved directory. However nothing prevents moved
> > directory from being modified and even converted from the inline format
> > to the normal format. When such race happens the rename code gets
> > confused and we crash. Fix the problem by locking the moved directory.
> >
> > CC: stable@xxxxxxxxxxxxxxx
> > Fixes: 32f7f22c0b52 ("ext4: let ext4_rename handle inline dir")
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > Link: https://lore.kernel.org/r/20230126112221.11866-1-jack@xxxxxxx
> > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> This commit has a reported regression
> (https://lore.kernel.org/linux-ext4/5efbe1b9-ad8b-4a4f-b422-24824d2b775c@kili.mountain),
> so probably it should not be backported quite yet.
Thanks, I've dropped it from everywhere now. Please let us know when
it's safe to add back to the tree.
greg k-h
