Re: Patch "cpufreq: fix cpufreq suspend/resume for intel_pstate" has been added to the 3.16-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/3/2014 10:36 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
This is a note to let you know that I've just added the patch titled

     cpufreq: fix cpufreq suspend/resume for intel_pstate

to the 3.16-stable tree which can be found at:
     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
      cpufreq-fix-cpufreq-suspend-resume-for-intel_pstate.patch
and it can be found in the queue-3.16 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


Please also add commit b1b12babe3b72cfb08b875245e5a5d7c2747c772 (cpufreq: update 'cpufreq_suspended' after stopping governors) on top of the one below (the one
below introduced a regression fixed by commit b1b12babe3b72cfb08).

 From 8e30444e153008e8eb3e74cbcb7a865bfcfb04a0 Mon Sep 17 00:00:00 2001
From: Lan Tianyu <tianyu.lan@xxxxxxxxx>
Date: Thu, 18 Sep 2014 15:03:07 +0800
Subject: cpufreq: fix cpufreq suspend/resume for intel_pstate

From: Lan Tianyu <tianyu.lan@xxxxxxxxx>

commit 8e30444e153008e8eb3e74cbcb7a865bfcfb04a0 upstream.

Cpufreq core introduces cpufreq_suspended flag to let cpufreq sysfs nodes
across S2RAM/S2DISK. But the flag is only set in the cpufreq_suspend()
for cpufreq drivers which have target or target_index callback. This
skips intel_pstate driver. This patch is to set the flag before checking
target or target_index callback.

Fixes: 2f0aea936360 (cpufreq: suspend governors on system suspend/hibernate)
Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>
[rjw: Subject]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
  drivers/cpufreq/cpufreq.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1666,6 +1666,8 @@ void cpufreq_suspend(void)
  	if (!cpufreq_driver)
  		return;
+ cpufreq_suspended = true;
+
  	if (!has_target())
  		return;
@@ -1680,8 +1682,6 @@ void cpufreq_suspend(void)
  			pr_err("%s: Failed to suspend driver: %p\n", __func__,
  				policy);
  	}
-
-	cpufreq_suspended = true;
  }
/**
@@ -1697,13 +1697,13 @@ void cpufreq_resume(void)
  	if (!cpufreq_driver)
  		return;
+ cpufreq_suspended = false;
+
  	if (!has_target())
  		return;
pr_debug("%s: Resuming Governors\n", __func__); - cpufreq_suspended = false;
-
  	list_for_each_entry(policy, &cpufreq_policy_list, policy_list) {
  		if (cpufreq_driver->resume && cpufreq_driver->resume(policy))
  			pr_err("%s: Failed to resume driver: %p\n", __func__,


Patches currently in stable-queue which might be from tianyu.lan@xxxxxxxxx are

queue-3.16/cpufreq-fix-cpufreq-suspend-resume-for-intel_pstate.patch

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]