On Tue, 7 Mar 2023 at 18:32, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> [ Upstream commit d8aca2f96813d51df574a811eda9a2cbed00f261 ]
>
> We don't stop transmissions in progress at shutdown. This is fine with
> FIFO SE mode but with DMA (support for which we'll introduce later) it
> causes trouble so fix it now.
>
> Fixes: e83766334f96 ("tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20221229155030.418800-2-brgl@xxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 57f04f8bf5043..851a5d2133aa2 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -891,6 +891,8 @@ static int setup_fifos(struct qcom_geni_serial_port *port)
> static void qcom_geni_serial_shutdown(struct uart_port *uport)
> {
> disable_irq(uport->irq);
> + qcom_geni_serial_stop_tx(uport);
> + qcom_geni_serial_stop_rx(uport);
> }
>
Greg,
Please drop this patch from all stable branches as it has caused a
problem in current master and - once fixed - is only relevant for new
(DMA) code.
Bartosz
