This is a note to let you know that I've just added the patch titled Target/iser: Don't put isert_conn inside disconnected handler to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: target-iser-don-t-put-isert_conn-inside-disconnected-handler.patch and it can be found in the queue-3.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 0fc4ea701fcf5bc51ace4e288af5be741465f776 Mon Sep 17 00:00:00 2001 From: Sagi Grimberg <sagig@xxxxxxxxxxxx> Date: Wed, 2 Jul 2014 16:19:25 +0300 Subject: Target/iser: Don't put isert_conn inside disconnected handler From: Sagi Grimberg <sagig@xxxxxxxxxxxx> commit 0fc4ea701fcf5bc51ace4e288af5be741465f776 upstream. disconnected_handler is invoked on several CM events (such as DISCONNECTED, DEVICE_REMOVAL, TIMEWAIT_EXIT...). Since multiple events can occur while before isert_free_conn is invoked, we might put all isert_conn references and free the connection too early. Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/infiniband/ulp/isert/ib_isert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -583,7 +583,6 @@ isert_disconnect_work(struct work_struct wake_up: complete(&isert_conn->conn_wait); - isert_put_conn(isert_conn); } static void @@ -2266,6 +2265,7 @@ static void isert_wait_conn(struct iscsi wait_for_completion(&isert_conn->conn_wait_comp_err); wait_for_completion(&isert_conn->conn_wait); + isert_put_conn(isert_conn); } static void isert_free_conn(struct iscsi_conn *conn) Patches currently in stable-queue which might be from sagig@xxxxxxxxxxxx are queue-3.10/target-iser-get-isert_conn-reference-once-got-to-connected_handler.patch queue-3.10/scsi-libiscsi-fix-potential-buffer-overrun-in-__iscsi_conn_send_pdu.patch queue-3.10/target-iser-don-t-put-isert_conn-inside-disconnected-handler.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html