On Wed, Mar 1, 2023 at 1:29 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> syzbot sent a hung task report and Eric explains that adversarial
> receiver may keep RWIN at 0 for a long time, so we are not guaranteed
> to make forward progress. Thread which took tx_lock and went to sleep
> may not release tx_lock for hours. Use interruptible sleep where
> possible and reschedule the work if it can't take the lock.
>
> Testing: existing selftest passes
>
> Reported-by: syzbot+9c0268252b8ef967c62e@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 79ffe6087e91 ("net/tls: add a TX lock")
> Link: https://lore.kernel.org/all/000000000000e412e905f5b46201@xxxxxxxxxx/
> Cc: stable@xxxxxxxxxxxxxxx # wait 4 weeks
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: borisp@xxxxxxxxxx
> CC: john.fastabend@xxxxxxxxx
> CC: simon.horman@xxxxxxxxxxxxx
>
This seems sane to me, thanks.
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
