This is a note to let you know that I've just added the patch titled
regmap: Fix handling of volatile registers for format_write() chips
to the 3.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
regmap-fix-handling-of-volatile-registers-for-format_write-chips.patch
and it can be found in the queue-3.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 5844a8b9d98ec11ce1d77610daacf3f0a0e14715 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@xxxxxxxxxx>
Date: Tue, 26 Aug 2014 12:12:17 +0100
Subject: regmap: Fix handling of volatile registers for format_write() chips
From: Mark Brown <broonie@xxxxxxxxxx>
commit 5844a8b9d98ec11ce1d77610daacf3f0a0e14715 upstream.
A previous over-zealous factorisation of code means that we only treat
registers as volatile if they are readable. For most devices this is fine
since normally most registers can be read and volatility implies
readability but for format_write() devices where there is no readback from
the hardware and we use volatility to mean simply uncacheability this means
that we end up treating all registers as cacheble.
A bigger refactoring of the code to clarify this is in order but as a fix
make a minimal change and only check readability when checking volatility
if there is no format_write() operation defined for the device.
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Tested-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/base/regmap/regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -109,7 +109,7 @@ bool regmap_readable(struct regmap *map,
bool regmap_volatile(struct regmap *map, unsigned int reg)
{
- if (!regmap_readable(map, reg))
+ if (!map->format.format_write && !regmap_readable(map, reg))
return false;
if (map->volatile_reg)
Patches currently in stable-queue which might be from broonie@xxxxxxxxxx are
queue-3.16/regmap-fix-handling-of-volatile-registers-for-format_write-chips.patch
queue-3.16/regmap-fix-regcache-debugfs-initialization.patch
queue-3.16/spi-dw-pci-fix-bug-when-regs-left-uninitialized.patch
queue-3.16/regmap-don-t-attempt-block-writes-when-syncing-cache-on-single_rw-devices.patch
queue-3.16/spi-dw-fix-kernel-crash-due-to-null-pointer-dereference.patch
queue-3.16/spi-omap-mcspi-fix-the-spi-task-hangs-waiting-dma_rx.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html