Re: [PATCH V2] rcu-tasks: Fix build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 21, 2023 at 05:34:34PM +0530, Srinivasarao Pathipati wrote:
> From: Srinivasarao Pathipati <quic_c_spathi@xxxxxxxxxxx>
> 
> Making show_rcu_tasks_rude_gp_kthread() function as 'inline' to
> fix below compilation error.
> This is applicable to only 5.10 kernels as code got modified
> in latest kernels.
> 
>  In file included from kernel/rcu/update.c:579:0:
>  kernel/rcu/tasks.h:710:13: error: ‘show_rcu_tasks_rude_gp_kthread’ defined but not used [-Werror=unused-function]
>   static void show_rcu_tasks_rude_gp_kthread(void) {}
> 
> Fixes: 8344496e8b49 ("rcu-tasks: Conditionally compile show_rcu_tasks_gp_kthreads()")
> Signed-off-by: Srinivasarao Pathipati <quic_c_spathi@xxxxxxxxxxx>
> ---
>  kernel/rcu/tasks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You didn't answer my "why is this an issue now" question.

Also, please document exactly what the modification was in Linus's tree
that prevents us from backportin gthat change here.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux