This is a note to let you know that I've just added the patch titled
usb: dwc3: core: fix order of PM runtime calls
to the 3.16-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-dwc3-core-fix-order-of-pm-runtime-calls.patch
and it can be found in the queue-3.16 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From fed33afce0eda44a46ae24d93aec1b5198c0bac4 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@xxxxxx>
Date: Tue, 2 Sep 2014 14:57:20 -0500
Subject: usb: dwc3: core: fix order of PM runtime calls
From: Felipe Balbi <balbi@xxxxxx>
commit fed33afce0eda44a46ae24d93aec1b5198c0bac4 upstream.
Currently, we disable pm_runtime before all register
accesses are done, this is dangerous and might lead
to abort exceptions due to the driver trying to access
a register which is clocked by a clock which was long
gated.
Fix that by moving pm_runtime_put_sync() and pm_runtime_disable()
as the last thing we do before returning from our ->remove()
method.
Fixes: 72246da (usb: Introduce DesignWare USB3 DRD Driver)
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/dwc3/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -791,15 +791,15 @@ static int dwc3_remove(struct platform_d
phy_power_off(dwc->usb2_generic_phy);
phy_power_off(dwc->usb3_generic_phy);
- pm_runtime_put_sync(&pdev->dev);
- pm_runtime_disable(&pdev->dev);
-
dwc3_debugfs_exit(dwc);
dwc3_core_exit_mode(dwc);
dwc3_event_buffers_cleanup(dwc);
dwc3_free_event_buffers(dwc);
dwc3_core_exit(dwc);
+ pm_runtime_put_sync(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
+
return 0;
}
Patches currently in stable-queue which might be from balbi@xxxxxx are
queue-3.16/usb-phy-tegra-avoid-use-of-sizeof-void.patch
queue-3.16/usb-host-xhci-fix-compliance-mode-workaround.patch
queue-3.16/usb-phy-twl4030-usb-fix-lost-interrupts-after-id-pin-goes-down.patch
queue-3.16/usb-dwc3-core-fix-ordering-for-phy-suspend.patch
queue-3.16/usb-chipidea-msm-use-usb-phy-api-to-control-phy-state.patch
queue-3.16/usb-dwc3-omap-fix-ordering-for-runtime-pm-calls.patch
queue-3.16/usb-gadget-f_rndis-fix-interface-id-for-os-descriptors.patch
queue-3.16/usb-dwc3-core-fix-order-of-pm-runtime-calls.patch
queue-3.16/usb-phy-twl4030-usb-fix-regressions-to-runtime-pm-on-omaps.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html