Re: [PATCH -trace] trace: fix TASK_COMM_LEN in trace event format file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 10 Feb 2023 11:27:18 -0500
Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:

> > --- a/include/trace/stages/stage4_event_fields.h
> > +++ b/include/trace/stages/stage4_event_fields.h
> > @@ -26,7 +26,8 @@
> >   #define __array(_type, _item, _len) {					\
> >   	.type = #_type"["__stringify(_len)"]", .name = #_item,		\  
> 
> Just out of curiosity, is the content of __stringify(_len) ever used 
> after this patch ? Perhaps we could remove it and just leave:
> 
> .type = #_type"[]"
> 
> considering that f_show appears to use the opening square bracket to 
> detect arrays. This would remove a few useless bytes of data.

I agree that we can optimize this. But lets make that a separate patch, and
not worry about it for this. That's a clean up that can be handled later.

I'd like to not add any more side effects than it may already have.

-- Steve



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux