Re: [PATCH 5.15 1/1] ext4: fix bad checksum after online resize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 24, 2023 at 09:06:32AM +0000, Oleksandr Tymoshenko wrote:
> From: Baokun Li <libaokun1@xxxxxxxxxx>
> 
> commit a408f33e895e455f16cf964cb5cd4979b658db7b upstream.
> 
> When online resizing is performed twice consecutively, the error message
> "Superblock checksum does not match superblock" is displayed for the
> second time. Here's the reproducer:
> 
> 	mkfs.ext4 -F /dev/sdb 100M
> 	mount /dev/sdb /tmp/test
> 	resize2fs /dev/sdb 5G
> 	resize2fs /dev/sdb 6G
> 
> To solve this issue, we moved the update of the checksum after the
> es->s_overhead_clusters is updated.
> 
> Fixes: 026d0d27c488 ("ext4: reduce computation of overhead during resize")
> Fixes: de394a86658f ("ext4: update s_overhead_clusters in the superblock during an on-line resize")
> Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> Cc: stable@xxxxxxxxxx
> Link: https://lore.kernel.org/r/20221117040341.1380702-2-libaokun1@xxxxxxxxxx
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

Any reason you forwarded on a modified patch and did not sign off on it
yourself?  Please fix that up and send it again.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux