Re: [RFC PATCH] selftests: Fix: search kernel headers in $(KHDR_INCLUDES)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/17/23 13:17, Mathieu Desnoyers wrote:
Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
building against kernel headers from the build environment in scenarios
where kernel headers are installed into a specific output directory
(O=...).


The change looks good to me.
[ Hopefully I did not break too many things with this selftests-wide
   change. Additional testing would be welcome before merging, especially
   given that whenever we get this wrong, it appears to fall-back on the
   build environment system headers, which hides issues. This applies on
   top of v6.2-rc3. ]


One concern with treewide change is the merge conflicts. Selftests
go through several trees as you may already know.

Would it be possible for you send patch series instead? Patch series
will help us avoid merge conflict issues.

I will run tests on this patch and let you know in the meatime.

thanks,
-- Shuah



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux