On Sat, Jan 21, 2023 at 09:50:13AM +0800, Kevin Hao wrote: > On Fri, Jan 20, 2023 at 02:40:32PM -0700, Tom Saeger wrote: > > > > applies but has build error: > > > > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c: In function ‘cpufreq_dbs_data_release’: > > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:393:49: error: implicit declaration of function ‘to_gov_attr_set’ [-Werror=implicit-function-declaration] > > 393 | struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); > > | ^~~~~~~~~~~~~~~ > > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:393:49: warning: passing argument 1 of ‘to_dbs_data’ makes pointer from integer without a cast [-Wint-conversion] > > 393 | struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); > > | ^~~~~~~~~~~~~~~~~~~~~ > > | | > > | int > > In file included from /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.c:20: > > /home/tsaeger/workspace/linux/linux-5.15.y/drivers/cpufreq/cpufreq_governor.h:49:65: note: expected ‘struct gov_attr_set *’ but argument is of type ‘int’ > > 49 | static inline struct dbs_data *to_dbs_data(struct gov_attr_set *attr_set) > > | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ > > cc1: some warnings being treated as errors > > > > > > 5.15.y first with: > > ae2650865127 ("cpufreq: Move to_gov_attr_set() to cpufreq.h") > > I managed to forget this commit. Please submit a working patch series that at least attempts to show you tested this :) thanks, greg k-h