Re: [5.15] Backport commit 0c25422d34b4 (scsi: mpt3sas: Remove scsi_dma_map() error messages)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 16, 2023 at 03:23:46PM +0100, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> Could you please apply commit 0c25422d34b4 (scsi: mpt3sas: Remove
> scsi_dma_map() error messages) to the 5.15.y series?
> 
> commit 0c25422d34b4726b2707d5f38560943155a91b80
> Author: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>
> Date:   Thu Mar 3 19:32:03 2022 +0530
> 
>     scsi: mpt3sas: Remove scsi_dma_map() error messages
> 
>     When scsi_dma_map() fails by returning a sges_left value less than zero,
>     the amount of logging produced can be extremely high.  In a recent
> end-user
>     environment, 1200 messages per second were being sent to the log buffer.
>     This eventually overwhelmed the system and it stalled.
> 
>     These error messages are not needed. Remove them.
> 
>     Link:
> https://lore.kernel.org/r/20220303140203.12642-1-sreekanth.reddy@xxxxxxxxxxxx
>     Suggested-by: Christoph Hellwig <hch@xxxxxx>
>     Signed-off-by: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>
>     Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> 
> We see this regression after upgrading from Linux 5.10 to 5.15 on our file
> servers with Broadcom/LSI SAS3008 PCI-Express Fusion-MPT SAS-3 (mpt3sas) –
> though luckily our systems do not stall/crash.
> 
> The commit message does not say anything about, what commit caused these
> error to be appearing – the log statements have been there since v4.20-rc1,
> if I am not mistaken, so it must be something else –, and also do not
> mention, why these log messages are not needed, but the new error condition
> is actually expected.

Now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux