Quoting Johan Hovold (2023-01-12 23:57:39) > On Thu, Jan 12, 2023 at 04:54:03PM -0800, Stephen Boyd wrote: > > From: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > > commit 2de8a325b1084330ae500380cc27edc39f488c30 upstream. > > > > Switch to using the device-managed of_iomap helper to avoid leaking > > memory on probe deferral and driver unbind. > > > > Note that this helper checks for already reserved regions and may fail > > if there are multiple devices claiming the same memory. > > This bit turned out to catch some buggy bindings and dts, so if you want > to backport this one then the corresponding fixes for that would be > needed as well. > > That includes > > a5d6b1ac56cb ("phy: qcom-qmp-usb: fix memleak on probe deferral") > > and some dts fixes which likely already have been backported. > > It may even be preferred to keep to just skip this patch and keep those > small memory leaks on probe deferral to not risk any regressions in > stable. I only see qcom,sm8350-qmp-usb3-uni-phy in the stable tree and that hasn't been changed since the node was introduced. I'll try to port the exclusive logic from a5d6b1ac56cb into this patch. I don't think it's preferable to keep the memory leak.