Re: [PATCH] ARM: 7897/1: kexec: Use the right ISA for relocate_new_kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014/9/25 17:53, Liu Hua wrote:
> From: Dave Martin <dave.martin@xxxxxxxxxx>
> 
> Hi Greg,
> 
> commit e2ccba49085ab5d71b092de2a5176eb9b19cc876 upstream

commit XXX upstream.  <-- don't forget the dot

> 
> Copying a function with memcpy() and then trying to execute the
> result isn't trivially portable to Thumb.
> 
> This patch modifies the kexec soft restart code to copy its
> assembler trampoline relocate_new_kernel() using fncpy() instead,
> so that relocate_new_kernel can be in the same ISA as the rest of
> the kernel without problems.
> 
> Without this patch THUMB2 kernel can not go through kdump process.
> I have test it  on 3.10. This patch applies to v3.13+. 3.10 stable
> and 3.12stable need it.
> 

Please don't stuff this into the middle of the original changelog...

> (1) A separate backport is needed for 3.10;

Then send out the backport.

> (2) it can apply to 3.12 stable directly.

3.12 is maintained by Jiri.

> 
> Signed-off-by: Dave Martin <Dave.Martin@xxxxxxx>
> Acked-by: Will Deacon <will.deacon@xxxxxxx>
> Reported-by: Taras Kondratiuk <taras.kondratiuk@xxxxxxxxxx>
> Tested-by: Taras Kondratiuk <taras.kondratiuk@xxxxxxxxxx>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> Integrated-by: Liu Hua <sdu.liu@xxxxxxxxxx>

Please remove this line.

> Signed-off-by: Liu Hua <sdu.liu@xxxxxxxxxx>

If the commit can be cherry-picked cleanly, just tell the stable
maintainer the commit ID, otherwise you should add changelog
for what you did to the original patch.

Like this:

https://lkml.org/lkml/2014/9/22/818

[lizf: Backported to 3.4:
 - Drop changes to arch/arm/include/asm/cacheflush.h and
   arch/arm/mach-exynos/mcpm-exynos.c]
Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>]

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]