Re: [PATCH 5.10 1/2] fsl_lpuart: Don't enable interrupts too early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 23, 2022 at 01:23:53PM +0900, Dominique Martinet wrote:
> From: Indan Zupancic <Indan.Zupancic@xxxxxxxxxxxx>
> 
> [ Upstream commit 401fb66a355eb0f22096cf26864324f8e63c7d78 ]
> 
> If an irq is pending when devm_request_irq() is called, the irq
> handler will cause a NULL pointer access because initialisation
> is not done yet.
> 
> Fixes: 9d7ee0e28da59 ("tty: serial: lpuart: avoid report NULL interrupt")
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Indan Zupancic <Indan.Zupancic@xxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20220505114750.45423-1-Indan.Zupancic@xxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [5.10 did not have lpuart_global_reset or anything after
> uart_add_one_port(), so add the remove call in cleanup manually]
> Signed-off-by: Dominique Martinet <dominique.martinet@xxxxxxxxxxxxxxxxx>
> ---
> This was originally intended as a prerequirement to backport the patch
> submitted in [1] for 5.10, but even with that part of the patch gone it
> makes sense as a fix on its own.
> 
> [1] https://lkml.kernel.org/r/20221222114414.1886632-1-linux@xxxxxxxxxxxxxxxxxx
> 
>  drivers/tty/serial/fsl_lpuart.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 

Both now queued up, thanks.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux